Skip to content

Conversation

@JustinBellavance
Copy link

@JustinBellavance JustinBellavance commented Dec 6, 2025

Bump ensembl-vep to 113.4 and change references to new seqera containers for vcf2maf.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@mashehu
Copy link
Contributor

mashehu commented Dec 6, 2025

Please use https links for the singularity container https://nf-co.re/docs/tutorials/nf-core_components/using_seqera_containers

@JustinBellavance
Copy link
Author

Please use https links for the singularity container https://nf-co.re/docs/tutorials/nf-core_components/using_seqera_containers

Didn't see that. Thanks for pointing me in the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants