Skip to content

Deprecate thumbnail's type attribute for #1605 #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PeterC-DLS wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Deprecate thumbnail's type attribute for #1605 #1606

PeterC-DLS wants to merge 1 commit into from

Conversation

@PeterC-DLS
Copy link
Contributor

@PeterC-DLS PeterC-DLS commented Jan 7, 2026

NXnote has a type field

@PeterC-DLS PeterC-DLS requested a review from a team January 7, 2026 11:21
@PeterC-DLS PeterC-DLS added this to the NXDL 2026.01 milestone Jan 7, 2026
@woutdenolf
Copy link
Contributor

woutdenolf commented Jan 7, 2026

I'm guessing this will need a vote. I'm all for it.

mkuehbach
mkuehbach approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@mkuehbach mkuehbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkuehbach mkuehbach mkuehbach approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

NXDL 2026.01

Development

Successfully merging this pull request may close these issues.

4 participants

@PeterC-DLS @woutdenolf @mkuehbach