-
Notifications
You must be signed in to change notification settings - Fork 66
Add NXtextlog base class #1590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add NXtextlog base class #1590
Conversation
7e236e9 to
7d588bd
Compare
7d588bd to
78f0cd6
Compare
|
Is it really necessary to create a new base class? Can't we just add a text array as an option to the NXlog class? We have just added dozens of new base classes, so perhaps I shouldn't complain about an extra one, but I think we need to be clear if it's really necessary. |
|
Hi Ray, this PR is in relation to #1432 which I forgot to reference in the PR description (have added now). In a previous discussion on this in #687 the consensus seemed to favor not changing |
|
I agree with Ray, but given Pete's comments in the other MR, if modifying NXlog isn't a possibility then NXnote with a timestamp (which was suggested originally too) could work without a new base class (, right?) |
|
|
|
From Jan 2026 telco, after discussing the various options including 1) this new base class, 2) changing NXlog to allow text data or 3) changing NXnote to allow timestamps, the cleanest option seems to be 1), so that's the proposal we'd like to go with. For now, this should go to contributed definitions, so a vote is not needed. Just need a approval. |
Proposal for an
NXtextlogbase class, this is similar toNXlogbut specifically for text based data asNXlogonly supports numeric data. It could be used for example to record status/error/log messages from hardware or software and meant to handle cases where a large number ofNXnoteentries is undesirable. See #1432 and #1591The implementation below currently has the option of a
separatorattribute to tell the reader how to split an indiidual value, but i'm not sure how useful that may or may not be. It may just be better to write multiple values in one log with the same timestamp, or as separateNXtextlogentries, for these cases.Other questions might be:
encodingattribute or just mandateUTF-8