Fairmat addition pr402 to em #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for fairmat-2024-em
…r NXapm was voted upon
…r with many examples in FAIRmat
Contributor
|
Hey folks, this PR comprises both base class renaming in response to comments from the original PR and some clean-up and bugfixes for NXapm. It does need a vote even though it's coming in on the heels of other FAIRmat work. Please vote on this comment, 👍 for yes, 👎 for no, anything else e.g. 👀 for abstain. Vote will close in two weeks. |
PeterC-DLS
reviewed
Sep 2, 2025
Contributor
Author
|
@phyy-nx @PeterC-DLS great that this passed, would need a review and then one can merge this in |
phyy-nx
approved these changes
Sep 9, 2025
Contributor
phyy-nx
left a comment
phyy-nx
left a comment
There was a problem hiding this comment.
Vote has passed, ok to merge
mkuehbach
pushed a commit
to FAIRmat-NFDI/nexus_definitions
that referenced
this pull request
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main