use consistent XML header #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterC-DLS
approved these changes
Jun 11, 2025
Contributor
PeterC-DLS
left a comment
PeterC-DLS
left a comment
There was a problem hiding this comment.
LGTM - great to be consistent!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1424, our automatic conversion tool
nyamlused to write XML headers with single quote (<?xml version='1.0' encoding='UTF-8'?>), but the standard in this repo is double quotes (<?xml version="1.0" encoding="UTF-8"?>).We have fixed this in the tool since, but there is as set of already standardized base classes from the FAIRmat proposal, where it was missed to fix the header before merging. This PR fixes these headers.
Can be checked by running
git grep -l "xml version='1.0'" base_classes/* applications/* contributed_definitions/*(returns nothing after this fix).