Add status code to splash page errors#2070
Draft
victorlin wants to merge 2 commits into
Draft
Conversation
In addition to response text and status text, keep the numeric HTTP status on FetchError.
Thread the structured status from failed fetches through the splash-page error path. goTo404 now accepts the status from FetchError, general state stores it next to the existing error message, and the default splash component renders the actual status code when one is available. Also preserve the status from the splash page's getAvailable request, since that request can fail independently of dataset loading. Document the new errorStatus prop for custom splash components. Code and commit message written by Codex Co-authored-by: Codex <codex@openai.com>
jameshadfield
left a comment
jameshadfield
left a comment
Member
There was a problem hiding this comment.
I think these are valuable improvements.
There are additional places FetchErrors are handled, such as loadSidecars, and it'd be nice to use the extra status-code information for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2068
Checklist