Fix streamtrees display for narratives#2051
Open
joverlee521 wants to merge 2 commits into
Open
Conversation
`showStreamTrees` was always getting set to false when loading the same dataset in narratives because the `treeToo` state is truthy when loading in the old state. Check `treeToo.loaded` to avoid showing streamtrees for tangletrees. Resolves #2050
joverlee521
force-pushed
the
fix-streamtree-narrative
branch
from
302575c to
eaf2fea
Compare
Member
|
John & I were just talking about this as your fix came through! ⭐ |
joverlee521
commented
May 20, 2026
Contributor
Author
There was a problem hiding this comment.
Now there's the opposite issue of once you reach a slide with streamLabel, going back to a previous slide stays in streamtrees display (unless you specifically set streamLabel=none for all previous slides).
joverlee521
commented
May 20, 2026
Contributor
Author
There was a problem hiding this comment.
@jameshadfield I'm not sure why this narrative doesn't work....see error in test-app
Member
There was a problem hiding this comment.
Will take a look, but might not be today
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
showStreamTreeswas always getting set to false when loading the same dataset in narratives because thetreeToostate is truthy when loading in the old state. ChecktreeToo.loadedto avoid showing streamtrees for tangletrees.Related issue(s)
Resolves #2050
Checklist