fix(config): treat GOCLAW_PROVIDER/MODEL env vars as fallback, not override#119
Merged
viettranx merged 1 commit intonextlevelbuilder:mainfrom Mar 10, 2026
Merged
Conversation
…erride The onboard wizard sets GOCLAW_PROVIDER and GOCLAW_MODEL in .env for initial bootstrap. Previously these env vars always overrode the config file value via envStr(), making it impossible to change the default provider/model through the Dashboard — every save was silently reverted by ApplyEnvOverrides(). Change envStr to envFallback for these two fields: the env var is only applied when the config file has no value (empty string). Once the user saves a provider/model via the Dashboard, the config-file value wins. Also: - Stabilize ProviderModelSelect auto-select effect (useRef + useMemo) - Add toast feedback on config save success/failure
Luvu182
force-pushed
the
fix/env-provider-fallback
branch
from
15d5797 to
3224da9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOCLAW_PROVIDERandGOCLAW_MODELin.envfor initial bootstrapenvStr(), making it impossible to change the default provider/model through the Dashboard — every save was silently reverted byApplyEnvOverrides()envStr→envFallbackfor these two fields: the env var is only applied when the config file has no value (empty string). Once the user saves a provider/model via the Dashboard, the config-file value winsProviderModelSelectauto-select effect withuseRef+useMemoto prevent unnecessary re-firesTest plan
GOCLAW_PROVIDER=fooandGOCLAW_MODEL=barin.envprovider/modelin config.json → verify defaults tofoo/barfrom env🤖 Generated with Claude Code