fix(feishu): response websocket event as success#110
Open
spencerswagger wants to merge 1 commit intonextlevelbuilder:mainfrom
Open
fix(feishu): response websocket event as success#110spencerswagger wants to merge 1 commit intonextlevelbuilder:mainfrom
spencerswagger wants to merge 1 commit intonextlevelbuilder:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Feishu WebSocket event response to properly acknowledge events with success status and include required frame identifiers (SeqID and LogID) for proper message correlation
Background: Feishu server marks pushed messages as failed because our response did not follow the documentation requirements, causing retry attempts. This resulted in a single user message triggering the channel multiple times.
Impact: This fix ensures proper event acknowledgment, eliminating duplicate message processing caused by Feishu server retries.
Changes
internal/channels/feishu/larkws.go:
code: 0withhttp.StatusOKfor better code semantics and readabilitySeqIDandLogIDfields to response frame, copied from the original request frame to ensure proper message correlation in WebSocket communicationTest plan