Skip to content

fix(feishu): response websocket event as success#110

Open
spencerswagger wants to merge 1 commit intonextlevelbuilder:mainfrom
spencerswagger:fix/feishu-event-always-retry
Open

fix(feishu): response websocket event as success#110
spencerswagger wants to merge 1 commit intonextlevelbuilder:mainfrom
spencerswagger:fix/feishu-event-always-retry

Conversation

@spencerswagger
Copy link
Contributor

@spencerswagger spencerswagger commented Mar 10, 2026

Summary

Fix Feishu WebSocket event response to properly acknowledge events with success status and include required frame identifiers (SeqID and LogID) for proper message correlation

Background: Feishu server marks pushed messages as failed because our response did not follow the documentation requirements, causing retry attempts. This resulted in a single user message triggering the channel multiple times.

Impact: This fix ensures proper event acknowledgment, eliminating duplicate message processing caused by Feishu server retries.

Changes

internal/channels/feishu/larkws.go:

  • Replace hardcoded code: 0 with http.StatusOK for better code semantics and readability
  • Add SeqID and LogID fields to response frame, copied from the original request frame to ensure proper message correlation in WebSocket communication

Test plan

  • Verify Feishu WebSocket connection can properly respond to events with success status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant