Store newlines as <br /> tag in new posted Notes#1148
Open
mnd wants to merge 1 commit into
Open
Conversation
mnd
force-pushed
the
create-post-with-newlines
branch
2 times, most recently
from
e233158 to
aa60d6f
Compare
Contributor
Author
|
Updated according to improvements from #1090 |
Contributor
Author
Replace is better because mastodon uses "white-space: pre-wrap" as default style and using |
ActivityStream assumes that content is HTML message: https://www.w3.org/TR/2017/REC-activitystreams-vocabulary-20170523/#dfn-content To fullfill this assumption save newlines as "<br />" during post creation and do not sanitize this "<br>" tag when post returned to the WEB interface. Additionally changed "strip_tags" call to format supported by php-7.3 Signed-off-by: Nikolai Merinov <nikolai.merinov@member.fsf.org>
mnd
force-pushed
the
create-post-with-newlines
branch
from
aa60d6f to
dbdf09c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActivityStream assumes that content is HTML message: https://www.w3.org/TR/2017/REC-activitystreams-vocabulary-20170523/#dfn-content
To fullfill this assumption save newlines as
<br />during post creationSigned-off-by: Nikolai Merinov nikolai.merinov@member.fsf.org
Summary
Suggested change should allow to store post in manner that allows to display it correctly on the web. Looks like other fediverse instances behave in similar manner. My only doubt is what better: use
nl2brphp function to have both newlines and<br \>tag, or usereplace()call to have only<br \>tag