Do not lose first newline in message#1140
Open
mnd wants to merge 1 commit into
Open
Conversation
When you create multiline notes like the following in Chromium 86.0.4240.198: > 1 > 2 > 3 You got the following HTML: "1<div>2</div><div>3</div>" without "<div>" block around first line. Add newline before first "<div>". This code also valid for IceCat 68.11.0esr where you got "<div>1</div><div>2</div><div>3</div>" in same case because final trim() call will remove leading newlines. Signed-off-by: Nikolai Merinov <nikolai.merinov@member.fsf.org>
Member
|
let's ping @StCyr @violoncelloCH @icewind1991 |
Contributor
Author
|
My own recommendation is to reject this pull request, but I wanted to spot the place with an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you create multiline notes like the following in Chromium 86.0.4240.198:
You got the following HTML:
1<div>2</div><div>3</div>without<div>block around first line. Add newline before first
<div>.This code also valid for IceCat 68.11.0esr where you got
<div>1</div><div>2</div><div>3</div>in same case because finaltrim()call will remove leading newlines.Signed-off-by: Nikolai Merinov nikolai.merinov@member.fsf.org
Summary
For messages created from Chromium browser I loose first newline in the message. Add a hack to bring it back.
NOTE I'ld prefer a better solution, but I barely familiar with web development and can't understand why chromium behave differently in this place