support Nextcloud running with private CA certificates#568
support Nextcloud running with private CA certificates#568icewind1991 merged 1 commit intonextcloud:mainfrom
Conversation
MarcelCoding
force-pushed
the
native-roots
branch
from
8e5c0d0 to
e5e2add
Compare
MarcelCoding
changed the title
allow to use custom ca certificates Signed-off-by: Marcel <me@m4rc3l.de>
MarcelCoding
force-pushed
the
native-roots
branch
from
e5e2add to
88eb113
Compare
|
While I'm open to making this change, it would be a breaking one, as some systems (like docker images) might not have any system certificate bundle in their current setup. I'm not sure if rustls has a proper way of doing a fallback to bundled certs so both cases could be covered |
|
I've looked at the code and it seemed like rustls just merged the system store and the hardcoded one. Although I did not test it. |
|
Maybe someone with a docker installation of notify_push can test this PR? |
|
I'll try to do some testing soon™ |
I can confirm that with the patch of @MarcelCoding it works as intended:
LGTM & thanks! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [nextcloud/notify_push](https://github.com/nextcloud/notify_push) | minor | `v1.0.0` -> `v1.1.0` | --- ### Release Notes <details> <summary>nextcloud/notify_push (nextcloud/notify_push)</summary> ### [`v1.1.0`](https://github.com/nextcloud/notify_push/releases/tag/v1.1.0): 1.1.0 [Compare Source](nextcloud/notify_push@v1.0.0...v1.1.0) #### What's Changed - Command\Setup: s/trough/through/ by [@​wonderfulShrineMaidenOfParadise](https://github.com/wonderfulShrineMaidenOfParadise) in nextcloud/notify_push#564 - support Nextcloud running with private CA certificates by [@​MarcelCoding](https://github.com/MarcelCoding) in nextcloud/notify_push#568 - track per-message type events by [@​icewind1991](https://github.com/icewind1991) in nextcloud/notify_push#587 - redis tls support by [@​icewind1991](https://github.com/icewind1991) in nextcloud/notify_push#598 - 1.1.0 by [@​icewind1991](https://github.com/icewind1991) in nextcloud/notify_push#603 - MSRV has increased to 1.81 #### New Contributors - [@​MarcelCoding](https://github.com/MarcelCoding) made their first contribution in nextcloud/notify_push#568 **Full Changelog**: nextcloud/notify_push@v1.0.0...v1.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC4zLjEiLCJ1cGRhdGVkSW5WZXIiOiI0MC4zLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://git.walbeck.it/walbeck-it/docker-nextcloud-notify-push/pulls/150 Co-authored-by: renovate-bot <bot@walbeck.it> Co-committed-by: renovate-bot <bot@walbeck.it>
3 participants
allow to use custom ca certificates