feat(desktop/appimage): use KDE Craft and their binary cache to get Qt #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
desktop/AppImageBuiltWithKdeCraft
branch
2 times, most recently
from
eacf2b9 to
92d5067
Compare
nilsding
reviewed
Jan 8, 2026
Contributor
Author
|
we also need a way to build the cache itself to be uploaded on our download server |
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
ensure proper search path for pkgconf by setting PKG_CONFIG_PATH env variable before calls to craft will enable the build to find libraries provided by the host system Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
desktop/AppImageBuiltWithKdeCraft
branch
from
f37cc0b to
24982c2
Compare
partilally rely on KDE binary cache for Craft enforce using Qt 6.9.3 for our stable branch Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
desktop/AppImageBuiltWithKdeCraft
branch
2 times, most recently
from
0133664 to
662725e
Compare
nilsding
approved these changes
Jan 13, 2026
mgallien
force-pushed
the
desktop/AppImageBuiltWithKdeCraft
branch
from
b93e619 to
7ede9aa
Compare
we have one image to build all dependencies: manual steps needed to get them into an archive one image to build the client with dependencies already there as binaries Signed-off-by: Matthieu Gallien <[email protected]>
switch to using Debian forky to get newer dependencies Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
desktop/AppImageBuiltWithKdeCraft
branch
from
7ede9aa to
8f756b7
Compare
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
desktop/AppImageBuiltWithKdeCraft
branch
from
8b9217b to
5a3a1ac
Compare
nilsding
reviewed
Jan 13, 2026
Comment on lines
+70
to
+74
| RUN \ | ||
| wget https://download.nextcloud.com/desktop/development/qt/${CRAFT_IMAGE} && \ | ||
| tar xf ${CRAFT_IMAGE} && \ | ||
| rm ${CRAFT_IMAGE} \ | ||
| ; |
Member
There was a problem hiding this comment.
Would it be possible to use the image from the Dockerfile.build.el8 as the base of this container? that way we wouldn't need to manually create/download+unpack an archive of the Craft installation, and we could also skip setting up the blueprint repositories here.
Contributor
Author
There was a problem hiding this comment.
we currently manually build Qt6 modules while building the first image
this is taking a lot of storage space and build time
I think the current limit when building an image would be exceeded
that is the main reason to keep a manual build step on some developer machine before using the actions to publish the final image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.