feat: implement IPartialShareProvider support #7501
+57
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
force-pushed
the
feature/54562/implement-ipartialshareprovider
branch
3 times, most recently
from
5036aee to
51b3ff9
Compare
artonge
force-pushed
the
feature/54562/implement-ipartialshareprovider
branch
from
a8757db to
51b3ff9
Compare
artonge
added
enhancement
3. to review
php
Signed-off-by: Louis Chmn <[email protected]>
Was v6.4.2 Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Salvatore Martire <[email protected]>
Signed-off-by: Salvatore Martire <[email protected]>
artonge
force-pushed
the
feature/54562/implement-ipartialshareprovider
branch
from
51b3ff9 to
104d414
Compare
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
Signed-off-by: Louis Chmn <[email protected]>
artonge
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements support for
IPartialShareProvider(nextcloud/server#57285)NOTE: IPartialMountProvider works on the assumption that the calls happens with a relatively up-to-date oc_mounts table (updated every 5 minutes and when accessing the user's root). For this reason it should be possible to skip checks (like membership or boards) as they are performed regularly.
TODO
Checklist