Conversation
Koc
force-pushed
the
feature/create-invitation-links
branch
5 times, most recently
from
97bbf10 to
d073a9b
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Koc
force-pushed
the
feature/create-invitation-links
branch
5 times, most recently
from
e887136 to
73eab05
Compare
Koc
force-pushed
the
feature/create-invitation-links
branch
2 times, most recently
from
76988ee to
f7d5f60
Compare
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/create-invitation-links
branch
from
f7d5f60 to
04cef57
Compare
Koc
requested review from
GVodyanov,
SebastianKrupinski and
hamza221
as code owners
|
|
||
| computed: { | ||
| circleUrl() { | ||
| return getBaseUrl() + generateUrl('apps/contacts/circle/{circleId}', { circleId: this.circleId }) |
There was a problem hiding this comment.
return generateUrl('/apps/contacts/circle/{circleId}', { circleId: this.circleId })
| // TODO: implement backend | ||
| // [CIRCLE_CONFIG_CIRCLE_INVITE]: t('contacts', 'Team must confirm when invited in another circle'), |
There was a problem hiding this comment.
I am assuming this todo is complete right?
There was a problem hiding this comment.
I'm not sure. This todo was created before I've started work on this task.
|
This is looking like a cool PR! I really like this feature, and the code (at least the front-end which I'm responsible for), is looking good. However, I am having an issue where I am not able to load my previously created teams when checking out your PR in circles, is this something others are also experiencing? |
|
@nfebe Hey! What do you think of this? You maintain the frontend for circles right? |
2 participants
This PR adds possibility to generate invitation link (even for completely hidden/closed Circles). Any user is able to join to C circle by opening this link.
Preview
Invitation link management
Invitation link opened
Invitation link opened when user already joined to a Circle
Invitation link opened when user already requested join to a Circle
Dependencies
Todo