Skip to content

Fix ecosystem account switching : add support for additional account formats#899

Merged
alperozturk96 merged 5 commits intomainfrom
fix/accountPatternRegex
Mar 3, 2026
Merged

Fix ecosystem account switching : add support for additional account formats#899
alperozturk96 merged 5 commits intomainfrom
fix/accountPatternRegex

Conversation

@sowjanyakch
Copy link
Contributor

STR:

This bug is also observed in files and notes app.

Exception: Ecosystem apps should support multiple valid account formats.

This PR supports additional account formats:

abc@cloud.com@example.inst2.cloud.com
admin@10.0.2.2:55002
admin@10.0.2.2

@sowjanyakch sowjanyakch self-assigned this Feb 25, 2026
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Feb 25, 2026
@alperozturk96
Copy link
Collaborator

I tested for

abc@cloud.com@example.inst2.cloud.com
admin@10.0.2.2
Screen.Recording.2026-02-26.at.08.54.12.mp4

All working except Talk client not using EcosystemManager.receiveAccount() thus selected account is not opening in the Talk but this needs to be implemented in Talk client separately.

@nickvergessen
Copy link
Member

Nextcloud can also be installed in a folder, so also test@example.tld@cloud.example.tld:443/subfolder/deep would be a valid cloud id

sowjanyakch and others added 5 commits March 2, 2026 13:56
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@nickvergessen
Copy link
Member

Don't need to wait for my approval here. test looks good

@alperozturk96 alperozturk96 merged commit 73f706d into main Mar 3, 2026
15 checks passed
@alperozturk96 alperozturk96 deleted the fix/accountPatternRegex branch March 3, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants