refactor: merge Nextcloud specific rules into the @nextcloud plugin#1278
Open
refactor: merge Nextcloud specific rules into the @nextcloud plugin#1278
@nextcloud plugin#1278Conversation
susnux
force-pushed
the
refactor/merge-nc-specific-plugins
branch
2 times, most recently
from
1e2d85f to
51e1a5c
Compare
susnux
force-pushed
the
refactor/merge-nc-specific-plugins
branch
from
51e1a5c to
e5b85e6
Compare
susnux
added
enhancement
Contributor
Author
|
I think the new names are easier to understand. Alternatives I have considered:
|
- `@nextcloud-l10n/enforce-ellipsis` -> `@nextcloud/l10n-enforce-ellipsis` - `@nextcloud-l10n/nonbreaking-space` -> `@nextcloud/l10n-non-breaking-space` - The vue variant has been merged into the base rule Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…moved-apis` Renamed so it does not confuse with vue rules after merging the plugins. - `@nextcloud/no-deprecations` -> `@nextcloud/no-deprecated-globals` - `@nextcloud/no-removed-apis` -> `@nextcloud/no-removed-globals` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- `@nextcloud-vue/no-deprecated-exports` -> `@nextcloud/no-deprecated-library-exports` - `@nextcloud-vue/no-deprecated-props` -> `@nextcloud/no-deprecated-library-props` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
refactor/merge-nc-specific-plugins
branch
from
e5b85e6 to
56e3105
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merged the
nextcloud-l10nplugin into thenextcloudpluginMerged the rules into the Nextcloud plugin, new rule names:
@nextcloud-l10n/enforce-ellipsis->@nextcloud/l10n-enforce-ellipsis@nextcloud-l10n/nonbreaking-space->@nextcloud/l10n-non-breaking-spaceThe vue variants have been merged into the base rules.
Renamed
@nextcloud/no-deprecationsand@nextcloud/no-removed-apisRenamed so it does not confuse with vue rules after merging the plugins.
New rule names:
@nextcloud/no-deprecations->@nextcloud/no-deprecated-globals@nextcloud/no-removed-apis->@nextcloud/no-removed-globalsMerged
@nextcloud-vueplugin into the@nextcloudpluginRule name changes:
@nextcloud-vue/no-deprecated-exports->@nextcloud/no-deprecated-library-exports@nextcloud-vue/no-deprecated-props->@nextcloud/no-deprecated-library-props