Fix tests related to next100 update#55
Conversation
This seems to be machine-dependent somehow
There was a problem hiding this comment.
Nice job!
I have one small issue, thought. I suggest removing the x_range, y_range in the config files since they no longer play any role on the evolution computation, but maybe this is not the most suitable PR for that since that does not affect the tests.
Other than that, I think it's just the commented assert on test_scrip_runs_and_produces_correct_outputs, apparently machine-dependent. How should we proceed now?
Done.
We have validated the code by other means, so I'm happy to ignore it for the time being |
carhc
left a comment
There was a problem hiding this comment.
Then I'm happy to approve this now! Nice update to tie up loose ends of the previous PR. Good job!
We pushed through #54 to get everything asap. Now we fix the tests.
The results seem to depend on the machine somehow, so for now this is ignored.