Skip to content

fix(attribute-workflow): resolve update attribute dictionary workflow issues #21471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(attribute-workflow): resolve update attribute dictionary workflow issues #21471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/protected-file-comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: xalvarez/[email protected]
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
pattern: .*attribute-dictionary\.json$
pattern: .*attribute-dictionary-.*\.json$
trustedAuthors: svc-docs-eng-opensource-bot

- name: Prevent ruby config file change
Expand All @@ -44,7 +44,7 @@ jobs:
with:
message: |
> [!WARNING]
> **`attribute-dictionary.json` is an autogenerated file.**
> **Attribute dictionary files (`attribute-dictionary-*.json`) are autogenerated files.**
>
> Changes to attribute dictionary should be made through the `attribute-dictionary` repo in GHE.

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-attribute-dictionary-json.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
run: |
git config --local user.email "${{ env.BOT_EMAIL }}"
git config --local user.name "${{ env.BOT_NAME }}"
git add src/data/attribute-dictionary.json
git add src/data/attribute-dictionary-en.json
git commit -m 'chore: Update Attribute Dictionary JSON'

- name: Create Pull Request
Expand Down
2 changes: 1 addition & 1 deletion scripts/actions/update-attribute-dictionary-json.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import sortBy from 'lodash/fp/sortBy.js';

// this should be prod nerdgraph
const NERDGRAPH_API_URL = 'https://api.newrelic.com/graphql';
const JSON_FILE_PATH = 'src/data/attribute-dictionary.json';
const JSON_FILE_PATH = 'src/data/attribute-dictionary-en.json';

const GQL_QUERY = `
{
Expand Down
Loading