Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #13 +/- ##
=======================================
Coverage 78.77% 78.77%
=======================================
Files 60 60
Lines 3524 3524
=======================================
Hits 2776 2776
Misses 748 748 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KyleQianliMa
approved these changes
Aug 11, 2025
Member
KyleQianliMa
left a comment
There was a problem hiding this comment.
Looks good to me. This makes the numpy version consistent with multiphonon's numpy version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
Set numpy min version in both pyproject.toml and recipe.yaml.
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References