Guard against monitored variable with pv_name equal to None#288
Merged
Guard against monitored variable with pv_name equal to None#288
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #288 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.01%
==========================================
Files 60 60
Lines 4434 4437 +3
==========================================
+ Hits 3666 3669 +3
Misses 768 768 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
darshdinger
approved these changes
Feb 19, 2026
Contributor
darshdinger
left a comment
There was a problem hiding this comment.
Tested the unit test, passes! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Add change to handle users adding an empty monitored PV list, which shows up in the database as a monitored PV with
pv_nameequal to None.In the future, we may want to change how monitored PV:s are added to disallow adding a non-valid value in the table.
Check all that apply:
References:
(Instructions for testing here)
Check list for the reviewer