Skip to content

Guard against monitored variable with pv_name equal to None#288

Merged
backmari merged 1 commit intonextfrom
defect15172_monitored_variable_none
Feb 19, 2026
Merged

Guard against monitored variable with pv_name equal to None#288
backmari merged 1 commit intonextfrom
defect15172_monitored_variable_none

Conversation

@backmari
Copy link
Collaborator

@backmari backmari commented Feb 19, 2026

Description of the changes

Add change to handle users adding an empty monitored PV list, which shows up in the database as a monitored PV with pv_name equal to None.

In the future, we may want to change how monitored PV:s are added to disallow adding a non-valid value in the table.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.69%. Comparing base (ed0a6a7) to head (ad82ebf).

Files with missing lines Patch % Lines
src/webmon_app/reporting/dasmon/view_util.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #288      +/-   ##
==========================================
+ Coverage   82.67%   82.69%   +0.01%     
==========================================
  Files          60       60              
  Lines        4434     4437       +3     
==========================================
+ Hits         3666     3669       +3     
  Misses        768      768              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@darshdinger darshdinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the unit test, passes! Looks good!

@backmari backmari merged commit 4e3b99d into next Feb 19, 2026
4 checks passed
@backmari backmari deleted the defect15172_monitored_variable_none branch February 19, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants