Change default plotly version used to display plots#287
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #287 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.02%
==========================================
Files 60 60
Lines 4434 4393 -41
==========================================
- Hits 3666 3633 -33
+ Misses 768 760 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
darshdinger
requested changes
Feb 19, 2026
Contributor
darshdinger
left a comment
There was a problem hiding this comment.
Two hopefully simple comments to address. Otherwise, looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Background: A CIS reported that a plot was showing up as empty. It had been created with
plotly6 (compatible with Plotly.JS 3.) but was missing the plotly version tag injected byplot_publisher. Since Mantid is usingplotly6 now, new plots are more likely to be compatible with Plotly.JS 3., which should also be backwards compatible with plots created using an older version.Check all that apply:
References:
(Instructions for testing here)
There is a manual test to verify that a plot created without a version tag is displayed using Plotly.JS 3.0.1.
/SNS/VULCAN/shared/autoreduce/reduce_VULCAN.py) are updated:InstrumentScientist.Check list for the reviewer