Skip to content

Stop Ignoring Ruff Linting#119

Merged
ktactac merged 3 commits intonextfrom
ewm15134-lint-cleanup
Feb 27, 2026
Merged

Stop Ignoring Ruff Linting#119
ktactac merged 3 commits intonextfrom
ewm15134-lint-cleanup

Conversation

@ktactac
Copy link
Collaborator

@ktactac ktactac commented Feb 26, 2026

Description of work:

Removes catch-all ruff lint rule ignoring from pyproject.toml and either fixes each case, or adds an in-line noqa in cases where external scripts may be impacted.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@ktactac ktactac self-assigned this Feb 26, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 81.69935% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.16%. Comparing base (d4c6005) to head (310464e).

Files with missing lines Patch % Lines
src/lr_reduction/time_resolved.py 70.58% 10 Missing ⚠️
src/lr_reduction/utils.py 0.00% 6 Missing ⚠️
src/lr_reduction/web_report.py 50.00% 5 Missing ⚠️
src/lr_reduction/event_reduction.py 90.62% 3 Missing ⚠️
src/lr_reduction/template.py 50.00% 2 Missing ⚠️
...c/lr_reduction/scaling_factors/LRScalingFactors.py 75.00% 1 Missing ⚠️
src/lr_reduction/workflow.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next     #119   +/-   ##
=======================================
  Coverage   85.16%   85.16%           
=======================================
  Files          23       23           
  Lines        2925     2925           
=======================================
  Hits         2491     2491           
  Misses        434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ktactac ktactac merged commit 0cde0d8 into next Feb 27, 2026
6 checks passed
@ktactac ktactac deleted the ewm15134-lint-cleanup branch February 27, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants