Skip to content

Move stitching out of legacy scaling_factors/ to avoid confusion#115

Merged
backmari merged 3 commits intonextfrom
move_stitching_from_scaling_factors
Mar 3, 2026
Merged

Move stitching out of legacy scaling_factors/ to avoid confusion#115
backmari merged 3 commits intonextfrom
move_stitching_from_scaling_factors

Conversation

@backmari
Copy link
Collaborator

@backmari backmari commented Feb 2, 2026

Description of work:

Some cleanup:

  • The modules in the folder scaling_factors/ are unrelated to stitching scaling factors. To avoid confusion, move the stitching functions into a separate module stitching.py. (This was suggested by @welbournR.)
  • Move all tests into either tests/unit/ or tests/integration/.
  • Remove the __all__ variable since wildcard imports are not recommended.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

⚠️ Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@backmari backmari force-pushed the move_stitching_from_scaling_factors branch from 2d11543 to 03cf89b Compare March 3, 2026 15:42
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.15%. Comparing base (3ce9476) to head (03cf89b).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #115      +/-   ##
==========================================
- Coverage   85.16%   85.15%   -0.02%     
==========================================
  Files          23       22       -1     
  Lines        2925     2923       -2     
==========================================
- Hits         2491     2489       -2     
  Misses        434      434              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@ktactac ktactac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR simply renames stitching files without trouble

@backmari backmari merged commit df01d17 into next Mar 3, 2026
6 checks passed
@backmari backmari deleted the move_stitching_from_scaling_factors branch March 3, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants