Move stitching out of legacy scaling_factors/ to avoid confusion#115
Merged
Move stitching out of legacy scaling_factors/ to avoid confusion#115
scaling_factors/ to avoid confusion#115Conversation
2d11543 to
03cf89b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #115 +/- ##
==========================================
- Coverage 85.16% 85.15% -0.02%
==========================================
Files 23 22 -1
Lines 2925 2923 -2
==========================================
- Hits 2491 2489 -2
Misses 434 434 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ktactac
approved these changes
Mar 3, 2026
Collaborator
ktactac
left a comment
There was a problem hiding this comment.
PR simply renames stitching files without trouble
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work:
Some cleanup:
scaling_factors/are unrelated to stitching scaling factors. To avoid confusion, move the stitching functions into a separate modulestitching.py. (This was suggested by @welbournR.)tests/unit/ortests/integration/.__all__variable since wildcard imports are not recommended.Check all that apply:
References:
(Instructions for testing here)
Check list for the reviewer