Skip to content

Conversation

@Levi080513
Copy link
Collaborator

@Levi080513 Levi080513 commented Nov 25, 2025

Issues

Changes

  1. Unified release package definition, default as manifest.yaml + some tar images.
├── images
│   └── docker.io-ubuntu-22.04.tar
└── manifest.yaml
  1. Extending engine import, now supports importing all types of offline packages.
## controlplane package import example
bin/neutree-cli  import controlplane --package scripts/builder/dist/neutree-control-plane-v0.1.0-nightly-20251122-amd64.tar.gz  --mirror-registry registry.example.com/neutree-test --registry-username=xxxx--registry-password=xxx

## cluster package import example
bin/neutree-cli  import cluster --package scripts/builder/dist/neutree-cluster-ssh-nvidia_gpu-v0.1.0-nightly-20251122-amd64.tar.gz  --server-url=http://10.255.1.54:3000 --api-key="xxxxx" --registry neutree-test

## engine package import example 
bin/neutree-cli  import engine --package scripts/builder/dist/vllm-v0.10.2.tar.gz  --server-url=http://10.255.1.54:3000 --api-key="xxxxx" --registry neutree-test

Test

Test import controlplane, cluster, engine package succeed

@Levi080513 Levi080513 requested a review from Copilot November 25, 2025 04:55
Copilot finished reviewing on behalf of Levi080513 November 25, 2025 04:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive package import functionality to Neutree, enabling users to build and import different types of packages (control plane, cluster, and engine) with container images.

  • Refactors package import functionality from pkg/engine to internal/cli/packageimport
  • Adds scripts for building packages with support for multi-architecture and mirror registries
  • Implements new CLI structure with neutree-cli import command supporting multiple package types
  • Adds validation capabilities for package integrity checking

Reviewed changes

Copilot reviewed 31 out of 32 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
scripts/builder/build-package.sh New script for building control plane and cluster packages
scripts/builder/build-engine-package.sh Updated engine package builder with new manifest format
scripts/builder/image-lists/* Image list files for different package types
internal/cli/packageimport/* Refactored package import functionality with improved structure
cmd/neutree-cli/app/cmd/packageimport/* New CLI commands for importing packages
pkg/client/client.go Added support for X-Neutree-Show-All header
pkg/engine/* Removed old engine-specific import code
cmd/neutree-cli/app/cmd/engine/* Removed old engine command structure
images.txt Root-level image list file
Comments suppressed due to low confidence (1)

cmd/neutree-cli/app/cmd/engine/import.go:1

  • The YAML delimiter in the documentation should be '---' (three hyphens), not '----' (four hyphens).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Levi080513 Levi080513 marked this pull request as ready for review November 25, 2025 06:59
@Levi080513 Levi080513 requested a review from Yuyz0112 November 25, 2025 07:23
@Levi080513 Levi080513 force-pushed the hw/cluster-import branch 2 times, most recently from 267a249 to 696d838 Compare November 25, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants