-
Notifications
You must be signed in to change notification settings - Fork 5
chore: support package import #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive package import functionality to Neutree, enabling users to build and import different types of packages (control plane, cluster, and engine) with container images.
- Refactors package import functionality from
pkg/enginetointernal/cli/packageimport - Adds scripts for building packages with support for multi-architecture and mirror registries
- Implements new CLI structure with
neutree-cli importcommand supporting multiple package types - Adds validation capabilities for package integrity checking
Reviewed changes
Copilot reviewed 31 out of 32 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/builder/build-package.sh | New script for building control plane and cluster packages |
| scripts/builder/build-engine-package.sh | Updated engine package builder with new manifest format |
| scripts/builder/image-lists/* | Image list files for different package types |
| internal/cli/packageimport/* | Refactored package import functionality with improved structure |
| cmd/neutree-cli/app/cmd/packageimport/* | New CLI commands for importing packages |
| pkg/client/client.go | Added support for X-Neutree-Show-All header |
| pkg/engine/* | Removed old engine-specific import code |
| cmd/neutree-cli/app/cmd/engine/* | Removed old engine command structure |
| images.txt | Root-level image list file |
Comments suppressed due to low confidence (1)
cmd/neutree-cli/app/cmd/engine/import.go:1
- The YAML delimiter in the documentation should be '---' (three hyphens), not '----' (four hyphens).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
4812f0e to
b049783
Compare
b049783 to
baf75b8
Compare
267a249 to
696d838
Compare
696d838 to
15e4e5a
Compare
Issues
Changes
Test
Test import controlplane, cluster, engine package succeed