Closed
Conversation
Owner
|
@nmoinvaz this looks great. My intention has always been to use the mainline pigz repository. However, I want to build production ready versions of pigz for each operating system. The mainline pigz does not support non-Latin characters on the Windows operating system. I would suggest we defer merging your PR until @madler has had a chance to review the pigz pull request that provides full Windows support. |
Copy necessary files from pigz dir and then build. Use mainline pigz and zlib repositories. Added rebuild and toolchain args to compile script.
Author
|
Closing this pull request. I have since added pigz-bench to zlib-ng organization which includes some of these improvements. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also removed
a_compile_dynamic.py. I'm not sure exactly of the purpose of it, but it seemed confusing to have two build scripts. It seems like we can accomplish the same thing witha_compile.pybut just add a another command line argument.