Remove deprecated program parameter#92
Open
richarddushime wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Open
Remove deprecated program parameter#92richarddushime wants to merge 1 commit intoneuroinformatics-unit:mainfrom
richarddushime wants to merge 1 commit intoneuroinformatics-unit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes removes the deprecated program parameter that was scheduled for removal in v0.7.0. According to this issue #76
Changes made :
Remove program parameter from start_logging() function signature
Remove the deprecation warning logic for program
Also simplifies error message when package is not passed
I Updated the tests to reflect the removal
What is this PR
Why is this PR needed?
The program parameter was deprecated in v0.6.0 and scheduled for removal
What does this PR do?
Removes the deprecated program parameter from
start_logging()and updates related tests.References
Please reference any existing issues/PRs that relate to this PR.
issue #76
How has this PR been tested?
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
I did run the tests and verified my changes
Is this a breaking change?
If this PR breaks any existing functionality, please explain how and why.
Does this PR require an update to the documentation?
no
If any features have changed, or have been added. Please explain how the
documentation has been updated.
Checklist: