Skip to content

Fix: Update keyboard shortcut tooltips for macOS compatibility (Fixes #617)#681

Closed
AdityaGupta716 wants to merge 0 commit intoneuroinformatics-unit:mainfrom
AdityaGupta716:main
Closed

Fix: Update keyboard shortcut tooltips for macOS compatibility (Fixes #617)#681
AdityaGupta716 wants to merge 0 commit intoneuroinformatics-unit:mainfrom
AdityaGupta716:main

Conversation

@AdityaGupta716
Copy link
Contributor

What is this PR

  • Bug fix

Why is this PR needed?

Issue #617 reported that the CTRL+Q keyboard shortcut tooltip is problematic on macOS because CTRL+Q quits the application on that platform. This PR updates the tooltip to emphasize CTRL+C (with SHIFT) instead, which is the correct way to copy the highlighted file path to the clipboard.

What does this PR do?

Updates keyboard shortcut tooltips in datashuttle/tui/tooltips.py to clarify that users should use CTRL+C with SHIFT to copy the filepath to the clipboard. This avoids the accidental application quit on macOS when users press CTRL+Q.

@JoeZiminski
Copy link
Member

Hi @AdityaGupta716 thanks for this. I think we will need to choose another key here, rather than CTRL+C with shift. CTRL+Q will copy the file path from the folder icon, but CTRL+C with shift will not do this, as it only copies what is visible on the screen. Maybe CTRL+W, CTRL+Q works well for this in all cases except macOS.

@AdityaGupta716
Copy link
Contributor Author

Ok i'll update the tooltip to suggest ctrl w instead so we avoid mac ctrl+q issue but still have a working shortcut

@JoeZiminski
Copy link
Member

Thanks @AdityaGupta716, we will need to change the key combination in the code as well. Ideally, we will find all instances of "CTRL+Q" / "ctrl+q", see where they are used, and manually test with CTR+W after updating them to ensure everything is working.

@AdityaGupta716
Copy link
Contributor Author

AdityaGupta716 commented Feb 16, 2026

@JoeZiminski i have changed the copy filepath from ctrl q to ctrl w and also changed the relevant codebase. i wasnt able to run the full TUI locally because some rclone related error but i did the changes u wanted me to do

@JoeZiminski
Copy link
Member

Thanks @AdityaGupta716 I'll take a look at this ASAP. What was the rclone related error you got? In general it is very useful to test locally on as many machines as possible before merging, thanks!

@AdityaGupta716
Copy link
Contributor Author

AdityaGupta716 commented Feb 20, 2026

Hi @JoeZiminski, I tested locally and ran into two issues: first rclone wasn't installed (fixed with brew install rclone), then the TUI crashed with an InvalidSelectValueError in configs_content.py line 747 related to the AWS region select widget — this appears to be a pre-existing bug unrelated to my CTRL+W changes. The grep confirms all instances of ctrl+q have been replaced with ctrl+w in tooltips.py, custom_widgets.py, and app.py.

@AdityaGupta716
Copy link
Contributor Author

AdityaGupta716 commented Feb 20, 2026

@JoeZiminski CTRL W wont work on mac cause it will actually delete the things we will try to copy in line i think CTRL K or maybe also CTRL Y can work

@JoeZiminski
Copy link
Member

Great thanks @AdityaGupta716, I'll play around on macOS a bit. Apologies for the delay in getting back to you, we are just planning to do a big release, after which we can focus on these PRs. CTRL+K or CTRL+Y seem like good ideas! Will have to review all keyboard shortcuts on the macOS,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants