-
-
Notifications
You must be signed in to change notification settings - Fork 31
added parallel implementations for number_
algorithms
#117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
A few observations: I ran the following with python3 test_should_run.py Contents of test_should_run.py :import networkx as nx
import logging
nxl = logging.getLogger("networkx")
nxl.addHandler(logging.StreamHandler())
nxl.setLevel(logging.DEBUG)
G = nx.empty_graph(5)
print(nx.number_of_isolates(G)) Output:
Note: Despite setting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure the fallback_to_networkx
flag applies to the case when you call the function with a graph input that is the backend graph type. That is, "fallback" means we have to convert the backend graph to a NetworkX graph and then call networkx. Perhaps there is a better name for this option. But I think that is why you are still getting the number of isolates. Your input is a NetworkX graph. So it will use the networkx version of the function whatever the value of "fallback_to_networkx" is.
9fa4c77
to
d7821d3
Compare
added parallel implementations for
These algorithms involve lightweight computations (e.g., simple summations), limiting their performance. Their behaviour should be analysed in context of PR #79.
[edit]: added the
should_run
parameter discussed in issue #77.