New article: The good will hunting problem #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossbar
changed the title
- Fix grammar - Fix broken links - Simplify wording in some places.
|
Okay, I had a chance to proofread so I think this is ready for another set of eyes! Here's a link to the rendered article: https://output.circle-artifacts.com/output/job/62a352da-a6b6-49bc-a08d-e7551a27541e/artifacts/0/site/_build/html/content/applications/goodwillhunting.html |
MridulS
reviewed
Jul 3, 2025
| # Position nodes hierarchically, with "root" on one end and "leaves" on the other | ||
| pos = nx.bfs_layout(G, 0) | ||
|
|
||
| nx.draw(G, pos=pos, ax=ax) |
There was a problem hiding this comment.
Can we use nx.display all around here?
There was a problem hiding this comment.
We could, though in this and the following sections, one of the points is that the same graph with different layouts can look completely different, so I think there's value in keeping the graphs and layouts independent, rather than storing the positions on the nodes.
Co-authored-by: Mridul Seth <[email protected]>
|
Thanks @MridulS , all excellent suggestions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I've been working on this weekend after a recent movie night!
I haven't done a copy-edit pass and there's still some formatting things to fix up, but feedback on high-level content and organization is most welcome!
Marking as draft for now as I don't want to subject anyone to the text until I've had a chance to apply some polish.