Skip to content

Make test case skip logic case-insensitive #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make test case skip logic case-insensitive #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57dc372
Add strings.ToLower to test case skipping condition
bszirtes Jul 15, 2025
73dd4e3
fix golangci-lint
bszirtes Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests_interdomain/interdomain_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
//
// Copyright (c) 2024 Pragmagic Inc. and/or its affiliates.
//
// Copyright (c) 2025 Nordix and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -21,6 +23,7 @@
package interdomain

import (
"strings"
"testing"

"github.com/stretchr/testify/suite"
Expand Down Expand Up @@ -55,7 +58,7 @@ type msmSuite struct {
}

func (s *msmSuite) BeforeTest(suiteName, testName string) {
if testName == "TestNsm_istio" {
if strings.EqualFold(testName, "testnsm_istio") {
s.T().Skip()
}
}
Expand Down
5 changes: 4 additions & 1 deletion tests_ovs_extended/feature_ovs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
//
// Copyright (c) 2024 Pragmagic Inc. and/or its affiliates.
//
// Copyright (c) 2025 Nordix and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -20,6 +22,7 @@ package ovsextra_test

import (
"flag"
"strings"
"testing"

"github.com/networkservicemesh/integration-tests/extensions/parallel"
Expand All @@ -35,7 +38,7 @@ type kindFeatOvsSuite struct {
}

func (s *kindFeatOvsSuite) BeforeTest(suiteName, testName string) {
if testName == "TestWebhook_smartvf" {
if strings.EqualFold(testName, "testwebhook_smartvf") {
s.T().Skip()
}
}
Expand Down
11 changes: 7 additions & 4 deletions tests_single/feature_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
//
// Copyright (c) 2024 Pragmagic Inc. and/or its affiliates.
//
// Copyright (c) 2025 Nordix and/or its affiliates.
//
// SPDX-License-Identifier: Apache-2.0
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -20,6 +22,7 @@ package single

import (
"flag"
"strings"
"testing"

"github.com/stretchr/testify/suite"
Expand All @@ -40,11 +43,11 @@ type calicoFeatureSuite struct {
}

func (s *calicoFeatureSuite) BeforeTest(suiteName, testName string) {
switch testName {
switch strings.ToLower(testName) {
case
"TestNse_composition",
"TestVl3_basic",
"TestVl3_scale_from_zero":
"testnse_composition",
"testvl3_basic",
"testvl3_scale_from_zero":
s.T().Skip()
}
}
Expand Down
9 changes: 5 additions & 4 deletions tests_single/ovs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2023-2024 Nordix Foundation.
// Copyright (c) 2023-2025 Nordix Foundation.
//
// SPDX-License-Identifier: Apache-2.0
//
Expand All @@ -18,6 +18,7 @@ package single

import (
"flag"
"strings"
"testing"

"github.com/networkservicemesh/integration-tests/extensions/parallel"
Expand All @@ -35,10 +36,10 @@ type kindOvsSuite struct {
}

func (s *kindOvsSuite) BeforeTest(suiteName, testName string) {
switch testName {
switch strings.ToLower(testName) {
case
"TestSmartVF2SmartVF",
"TestKernel2KernelVLAN":
"testsmartvf2smartvf",
"testkernel2kernelvlan":
s.T().Skip()
}
}
Expand Down
Loading