n-dhcp4: add new client probe function to send RELEASE message #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new function uses the client probe connection to send a RELEASE message. Returns zero if successful otherwise returns non-zero value. Signed-off-by: Fernando Fernandez Mancera <[email protected]>
dvdhrm
requested changes
Mar 20, 2024
|
|
||
| r = n_dhcp4_c_connection_start_request(&probe->connection, request_out, 0); | ||
| if (r) | ||
| return r; |
Member
There was a problem hiding this comment.
This will keep resending the DHCPDECLINE message, since it stays in connection->request. I think you need to use n_dhcp4_c_connection_send_request() directly, don't you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new function uses the client probe connection to send a RELEASE message. Returns zero if successful otherwise returns non-zero value.