Add a couple bug fixes to SublimeBlockCursor.py. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew_is_widget was defined as a method, but used like a function. So, moved it out of the class and added a None type check, to suppress some errors I saw in the console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a
NameError, asview_is_widgetwas defined as a method, but used like a function. So, moved it out of the class, although a smaller fix would have been to just addself.to theview_is_widgetcall, inon_selection_modified().Also, added a None type check, to suppress some errors I saw in the console. The latter fix is slightly different to, but addresses the same issue reported in PR #13. Only just seen that PR, but I applied the patch a while ago, so I'm not exactly sure under what circumstances that error message is produced...