Add feature: add support for creating and updating WhatsApp message templates #227
Conversation
krishna035
commented
May 19, 2025
krishna035
commented
- Introduced CreateTemplateRequest and UpdateTemplateRequest classes
- Added createTemplate() and updateTemplate() methods in Client
- Exposed createTemplate and updateTemplateById in WhatsAppCloudApi
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for creating and updating WhatsApp message templates via the Cloud API.
- Introduced
CreateTemplateRequestandUpdateTemplateRequestclasses - Added
createTemplate()andupdateTemplateById()toWhatsAppCloudApi - Extended
ClientwithcreateTemplate()/updateTemplate()and updated README with usage examples
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WhatsAppCloudApi.php | New wrapper methods createTemplate & updateTemplateById |
| src/Request/TemplateRequest/CreateTemplateRequest.php | Request class for creating message templates |
| src/Request/TemplateRequest/UpdateTemplateRequest.php | Request class for updating message templates |
| src/Client.php | Added createTemplate() & updateTemplate() handlers |
| README.md | Added code examples and updated feature list |
Comments suppressed due to low confidence (2)
src/WhatsAppCloudApi.php:627
- Consider adding unit or integration tests for
createTemplate(andupdateTemplateById) to exercise both success paths and error-subcode handling.
public function createTemplate(string $name, string $category, string $language, array $components): Response
src/WhatsAppCloudApi.php:670
- Import
UpdateTemplateRequestat the top and instantiate it directly (e.g.,new UpdateTemplateRequest(...)) to mirror theCreateTemplateRequestusage and improve consistency.
new Request\TemplateRequest\UpdateTemplateRequest(
src/WhatsAppCloudApi.php
Outdated
|
|
||
| if ( | ||
| isset($decoded['error']['error_subcode']) && | ||
| (int)$decoded['error']['error_subcode'] === 2388024 |
There was a problem hiding this comment.
[nitpick] Unify how you check error_subcode between createTemplate and updateTemplateById. Either remove the explicit cast here or apply the same strict comparison pattern in both methods.
| (int)$decoded['error']['error_subcode'] === 2388024 | |
| $decoded['error']['error_subcode'] === 2388024 |
src/WhatsAppCloudApi.php
Outdated
| try { | ||
| return $this->client->createTemplate($request); | ||
| } catch (\Netflie\WhatsAppCloudApi\Response\ResponseException $e) { | ||
| $decoded = json_decode($e->getMessage(), true); |
There was a problem hiding this comment.
Decoding the exception message may not reliably yield the raw API error body. Consider exposing or using a getter on ResponseException that returns the original response payload for parsing.
| $decoded = json_decode($e->getMessage(), true); | |
| $decoded = json_decode($e->getResponsePayload(), true); |
src/Client.php
Outdated
| * | ||
| * @throws \Netflie\WhatsAppCloudApi\Response\ResponseException | ||
| */ | ||
| public function createTemplate(CreateTemplateRequest $request): Response |
There was a problem hiding this comment.
The logic in createTemplate and updateTemplate is almost identical. Extract the common request/response flow into a private helper to reduce duplication.
|
|
||
| $whatsapp->createTemplate( | ||
| 'seasonal_promotion', | ||
| 'MARKETING', // UTILITY | MARKETING | AUTHENTICATION |
There was a problem hiding this comment.
The comment lists common template categories but omits TRANSACTIONAL. Update this to reflect all supported categories for clarity.
There was a problem hiding this comment.
I checked the official documentation link and did not find a TRANSACTIONAL category listed.
Can you clarify where you found that category or if it might be a legacy or deprecated term?
- Extracted the common JSON request/response logic in Client class to a private sendJsonRequest helper method. - Replaced the usage of getMessage() with responseData() in ResponseException for better error body parsing. - Removed redundant error decoding logic in updateTemplateById and similar methods. - Updated docblocks throughout Client class for clarity and maintainability.
1 participant
