fix(reconciler): remove hardcoded sslmode config #406
+19
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, ssl mode was not configurable when creating a connection to the postgres database. while the lack of SSL is acceptable for local deployments (i.e., dockerized postgres in-cluster), we hit security restrictions when trying to connect to external databases (like AWS). this commit allows the operator to configure the ssl mode to their liking.
anshulkamath
requested review from
jajeffries,
leoparente,
ltucker,
mfiedorowicz and
MicahParks
as code owners
|
|
|
@anshulkamath Thanks for contribution, could you sign the CLA, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, ssl mode was not configurable when creating a connection to the postgres database. while the lack of SSL is acceptable for local deployments (i.e., containerized postgres in-cluster), we hit security restrictions when trying to connect to external databases (like RDS). this commit allows the operator to configure the ssl mode to their choosing.