Skip to content

WIP feat: basic deduplication of ingested entities #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

WIP feat: basic deduplication of ingested entities #383

wants to merge 4 commits into from

Conversation

ltucker
Copy link
Contributor

@ltucker ltucker commented Jul 11, 2025

WIP deduplication of ingested entities

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2025 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 1.25s github.com/netboxlabs/diode/diode-server/auth 43.9% 41 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/auth/cli 0.0% 0 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/authutil 82.8% 5 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.11s github.com/netboxlabs/diode/diode-server/entityhash 86.7% 16 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/errors 0.0% 0 0 0
🟢 PASS 1.23s github.com/netboxlabs/diode/diode-server/ingester 83.6% 25 0 0
🟢 PASS 1.05s github.com/netboxlabs/diode/diode-server/migrator 70.4% 4 0 0
🟢 PASS 3.12s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 84.7% 31 0 0
🟢 PASS 2.30s github.com/netboxlabs/diode/diode-server/reconciler 81.9% 77 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/reconciler/applier 85.7% 1 0 0
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.06s github.com/netboxlabs/diode/diode-server/reconciler/differ 54.0% 6 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.03s github.com/netboxlabs/diode/diode-server/telemetry 28.0% 26 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/telemetry/otel 91.7% 25 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 2 0 0

Total coverage: 52.5%

@ltucker ltucker force-pushed the dedupe branch 2 times, most recently from cd99da5 to 6e83a0f Compare July 11, 2025 19:05
mfiedorowicz
mfiedorowicz approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@mfiedorowicz mfiedorowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one ask to check if logs in CreateIngestionLog method are sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfiedorowicz mfiedorowicz mfiedorowicz approved these changes

@jajeffries jajeffries Awaiting requested review from jajeffries jajeffries will be requested when the pull request is marked ready for review jajeffries is a code owner

@leoparente leoparente Awaiting requested review from leoparente leoparente will be requested when the pull request is marked ready for review leoparente is a code owner

Assignees
No one assigned
Labels
dependencies diode-proto diode-reconciler diode-server documentation Improvements or additions to documentation go markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltucker @mfiedorowicz