NetBox v4.3.5 - QuickFix - QuerySetNotOrdered in API viewsets #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added explicit `.order_by('-pk')` to all queryset definitions in API viewsets to resolve QuerySetNotOrdered errors in API calls.
- Ensures consistent and predictable ordering for all NetBoxModelViewSet
- Due to netbox-community/netbox#18900
|
good spot @Kani999 - thanks, but I think I'm going to put ordering on models instead as a fuller fix - will make sure credit is given for highlighting this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.order_by('-pk')to all queryset definitions in API viewsets to resolve QuerySetNotOrdered errors in API calls.This is only a quick fix for using the API in NetBox 4.3.5 and above.
The correct solution should be to set the
orderingattribute in theclass Meta:of the model.