Skip to content

Conversation

@topimiettinen
Copy link
Collaborator

Rebased and updated from #4656 by @rusty-snake.

@topimiettinen topimiettinen added the WIP: DON'T MERGE A PR that is still being worked on label Apr 13, 2024
@topimiettinen topimiettinen marked this pull request as draft April 13, 2024 12:05
@topimiettinen topimiettinen force-pushed the meson branch 6 times, most recently from 21cf1b3 to f217d37 Compare April 14, 2024 20:55
Rebased and updated from netblue30#4656 by rusty-snake.

Closes: netblue30#4642
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting to see how another build system would do things, but I
personally don't really see this as an improvement.

Even if rough around the edges at times, both firejail and autoconf/make are
relatively self-contained and have minimal dependencies, which is what I
personally find to be one of their biggest appeals as projects.

If the main goal of this is to mitigate what led to the xz attack, I have
posted a few (less drastic) suggestions in #6316.

Other than that, autoconf and make seem to work fine for their intended purpose
and quite a few build system improvements were made since #4642 was opened (and
I have some more in mind). If there is something else that could be improved
or clarified, feel free to open an issue about it.

@topimiettinen
Copy link
Collaborator Author

I personally find this a nice improvement, especially in view of xz attack. Meson's syntax is also cleaner and the builds are faster.

I'd argue that there isn't that great difference between dependencies of auto**** and make vs. meson & ninja. The difference isn't also very meaningful these days, probably it would be a very niche case to build Firejail in such resource constrained embedded system where it would matter.

My feeling for auto**** is that unfortunately the architecture seems to be such a mess that it's not possible to improve it much, especially from our side. But if you find it important to keep using the old way, it's certainly possible to support both build systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP: DON'T MERGE A PR that is still being worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants