-
Notifications
You must be signed in to change notification settings - Fork 54
Add support for multiple continuous input ports #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
pynestml/codegeneration/resources_nest/point_neuron/common/NeuronClass.jinja2
Outdated
Show resolved
Hide resolved
pynestml/codegeneration/resources_nest/point_neuron/common/NeuronHeader.jinja2
Outdated
Show resolved
Hide resolved
v_m1 = nest.GetStatus(mm, "events")[0]["V_m1"] | ||
v_m2 = nest.GetStatus(mm, "events")[0]["V_m2"] | ||
|
||
np.testing.assert_allclose(v_m1[-1], 2370) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these values be derived from the number of steps taken and DC amplitudes? By that token, why is this value 2370 and not 3000?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not the direct addition of the current, but a cumulative sum divided by conductance V_m1 += I_1 / 5 nS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The input is 150 and the script simulates for 10 ms at 0.1 ms resolution, so a total of 100 timesteps. There is a factor 1/5 in the script, so the total should be 150*100/3 = 3000, not 2370, right? Can you explain where the value 2370 comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also take delay
into consideration, which is 1 ms
by default (10 timesteps), and we add the external current at the end of the update()
function, i.e., after all the update statements are executed. Also, the multimeter records 90 values, which I think is due to the min_delay
. Taking all these into consideration, the final value of V_m = (90-11)*150/5 = 2370
.
No description provided.