Skip to content

Add support for multiple continuous input ports #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

pnbabu
Copy link
Contributor

@pnbabu pnbabu commented May 23, 2025

No description provided.

Copy link

github-actions bot commented Jun 4, 2025

🐰 Bencher Report

Branch1218/merge
Testbedubuntu-latest

🚨 1 Alert

IterationBenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
0tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapseLatency
seconds (s)
📈 plot
🚷 threshold
🚨 alert (🔔)
4.01 s
(+16.26%)Baseline: 3.45 s
3.79 s
(105.69%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
4.01 s
(+16.26%)Baseline: 3.45 s
3.79 s
(105.69%)

BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3.37 s
(-1.88%)Baseline: 3.44 s
3.78 s
(89.20%)

BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3.42 s
(-0.69%)Baseline: 3.44 s
3.79 s
(90.28%)

🐰 View full continuous benchmarking report in Bencher

@pnbabu pnbabu marked this pull request as ready for review June 26, 2025 13:33
@pnbabu pnbabu requested a review from clinssen June 26, 2025 13:33
v_m1 = nest.GetStatus(mm, "events")[0]["V_m1"]
v_m2 = nest.GetStatus(mm, "events")[0]["V_m2"]

np.testing.assert_allclose(v_m1[-1], 2370)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these values be derived from the number of steps taken and DC amplitudes? By that token, why is this value 2370 and not 3000?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the direct addition of the current, but a cumulative sum divided by conductance V_m1 += I_1 / 5 nS.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input is 150 and the script simulates for 10 ms at 0.1 ms resolution, so a total of 100 timesteps. There is a factor 1/5 in the script, so the total should be 150*100/3 = 3000, not 2370, right? Can you explain where the value 2370 comes from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also take delay into consideration, which is 1 ms by default (10 timesteps), and we add the external current at the end of the update() function, i.e., after all the update statements are executed. Also, the multimeter records 90 values, which I think is due to the min_delay. Taking all these into consideration, the final value of V_m = (90-11)*150/5 = 2370.

@pnbabu pnbabu requested a review from clinssen July 9, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants