Skip to content

Replace SledBackend by ckb-rocksdb #4956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Replace SledBackend by ckb-rocksdb #4956

wants to merge 6 commits into from

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Sep 17, 2025 •
edited
Loading

What problem does this PR solve?

This PR want to fix: #4518

Related changes

  • Remove trait KeyValueBackend, since it has only one impl for struct HeaderMapKernel
  • Move shared_best_header field from struct SyncState to struct Shared
  • Persist HeaderMap.memory and shared_best_header to SledBackend

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner September 17, 2025 04:40
@eval-exec eval-exec requested review from quake and removed request for a team September 17, 2025 04:40
@eval-exec eval-exec force-pushed the exec-header-sync-persist branch 3 times, most recently from c4a5b40 to 2996109 Compare September 17, 2025 05:01
@eval-exec eval-exec changed the title Persist HeaderMap and shared_best_header to SledBackend Persist HeaderMap and shared_best_header to SledBackend Sep 17, 2025
@eval-exec eval-exec force-pushed the exec-header-sync-persist branch from 2996109 to a6b5588 Compare September 17, 2025 05:26
@eval-exec eval-exec changed the title Persist HeaderMap and shared_best_header to SledBackend Replace SledBackend by ckb-rocksdb Sep 26, 2025
@eval-exec eval-exec force-pushed the exec-header-sync-persist branch from 1498151 to 62c0d5d Compare October 28, 2025 02:46
@eval-exec eval-exec marked this pull request as draft October 28, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cache header validation point (in case of crash)

1 participant

@eval-exec