Skip to content

[BREAKING CHANGE] Add multisig_v2 to devchain #4872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[BREAKING CHANGE] Add multisig_v2 to devchain #4872

wants to merge 3 commits into from

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Apr 14, 2025 •
edited
Loading

What is changed and how it works?

Related changes

  • For devchain, add MULTISIG_ALL_V2 to devchain's genesis block.
  • Allow multisig_v2 script pass WellKnownScriptsOnlyValidator for OutputsValidator
  • Add doc for get_consensus RPC, note that the secp256k1_blake160_multisig_all_type_hash is deprecated.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • It's a BREAKING CHANGE for dev chain, since we modified devchain's genesis block.

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner April 14, 2025 05:04
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team April 14, 2025 05:04
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch from 5ea280d to 71886ff Compare April 14, 2025 05:06
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch 3 times, most recently from debc72a to 9ce2bb0 Compare April 28, 2025 06:36
@eval-exec eval-exec changed the title rpc: add notes for get_consensus rpc multisig will upgrade Add multisig_v1 to devnet. Apr 28, 2025
@eval-exec eval-exec changed the title Add multisig_v1 to devnet. [WIP] Add multisig_v1 to devnet. Apr 28, 2025
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch from 89e8463 to 6d9af80 Compare April 28, 2025 08:45
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch 4 times, most recently from 6b09ac7 to 7203820 Compare May 8, 2025 05:43
@eval-exec eval-exec changed the title [WIP] Add multisig_v1 to devnet. [WIP] Add multisig_v1 to devchain May 8, 2025
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch from 7203820 to 4097940 Compare May 15, 2025 06:57
@eval-exec eval-exec changed the title [WIP] Add multisig_v1 to devchain [WIP] Add multisig_v2 to devchain May 20, 2025
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch from 4097940 to 11b5396 Compare May 20, 2025 06:10
@eval-exec
Copy link
Collaborator Author

eval-exec commented May 21, 2025 •
edited
Loading

TODO: add multisig_v2 script to OutputsValidator::WellKnownScriptsOnly @eval-exec

@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch 5 times, most recently from 9dba0c7 to e76c673 Compare May 21, 2025 09:33
eval-exec
eval-exec commented May 23, 2025
View reviewed changes
resource/specs/dev.toml
name = "secp256k1_blake160_multisig_all_v2"
files = [
{ bundled = "specs/cells/secp256k1_data" },
{ version = "v0.6.0", bundled = "specs/cells/secp256k1_blake160_multisig_all" },
Copy link
Collaborator Author

@eval-exec eval-exec May 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add a new field: ckb-system-scripts's version to DepGroup.
ckb-system-scripts v0.5.4's specs/cells/secp256k1_blake160_multisig_all is legacy multisig.
ckb-system-scripts v0.6.0's specs/cells/secp256k1_blake160_multisig_all is v2 multisig.

If version field is missing, default to [email protected]

@driftluo @zhangsoledad @quake @doitian

@eval-exec eval-exec changed the title [WIP] Add multisig_v2 to devchain [BREAKING CHANGE] Add multisig_v2 to devchain May 23, 2025
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch 3 times, most recently from 82783a7 to 7aa84ea Compare May 26, 2025 08:46
@eval-exec eval-exec requested a review from chenyukang May 26, 2025 09:16
@eval-exec eval-exec requested a review from driftluo May 26, 2025 09:16
@eval-exec eval-exec added the b:rpc Break RPC interface label May 26, 2025
@eval-exec eval-exec requested review from doitian and quake May 26, 2025 09:16
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch 3 times, most recently from 064138d to 8fee8bc Compare June 9, 2025 04:56
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch 2 times, most recently from 2ab47a1 to 69f6db6 Compare June 15, 2025 05:15
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch from 58866e3 to 63995cf Compare July 4, 2025 06:46
@eval-exec eval-exec force-pushed the exec/note-consensus-rpc-multisig branch from 63995cf to d4806f6 Compare July 4, 2025 06:47
@github-actions
Copy link

github-actions bot commented Aug 19, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale To be closed due to a lack of activity label Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

@chenyukang chenyukang Awaiting requested review from chenyukang

@driftluo driftluo Awaiting requested review from driftluo

@quake quake Awaiting requested review from quake

@doitian doitian Awaiting requested review from doitian

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

b:rpc Break RPC interface stale To be closed due to a lack of activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eval-exec