Rename MCP and Mastra tools at register time - #569
Open
andrelandgraf wants to merge 5 commits into
Open
andrelandgraf wants to merge 5 commits into
andrelandgraf wants to merge 5 commits into
Conversation
createNeonTools({ names }) is too early for a host that only sees the catalog at registerNeonTools / toMastraTools.
toMastraTools({ name }) published neon_list_projects at runtime while TypeScript still typed list_projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
registerNeonToolsandtoMastraToolsiterateObject.values(tools)and publishtool.id. A host that remaps the catalog ({ listProjects: tools.list_projects }) still publisheslist_projects. Renaming meant going back tocreateNeonTools({ names }). Two tools that collide onidfailed inside the MCP SDK, not in Neon.Solution
Optional
{ name?: (tool) => string }on both adapters. Duplicate published names throw beforeregisterTool.Default is still
tool.id.toMastraTools(tools)stays keyed byTool["id"].toMastraTools(tools, { name })returnsRecord<string, { id: string; … }>.Verification
pnpm --filter @neon/sdk buildpnpm --filter @neon/tools tscpnpm --filter @neon/tools exec vitest runneon_list_projectswhennameprefixestool.idname()results throwDuplicate published tool name "same"with zeroregisterToolcallsidfollows the samenamefunctionlist_projects;{ name }typesneon_list_projects.idasstringGaps
createNeonTools({ names })is unchanged. This option is only the adapter publish name.A
namefunction's return type isstring, so TypeScript cannot prove a specific key like"neon_list_projects"is the only key.