feat: add EC2 UserData support for AWS provider#328
Merged
mrizwan93 merged 1 commit intoneoave:mainfrom Mar 26, 2026
Merged
Conversation
7fca8ac to
cb7de9c
Compare
dav-pascual
reviewed
Mar 20, 2026
Member
dav-pascual
left a comment
There was a problem hiding this comment.
Hi @mrizwan93
Thank you for the changes and you first mrack contribution :)
Apart from other comments:
- Could you add an example to /src/mrack/data/provisioning-config.yaml for reference?
- Could you add unit test?
A couple of commit of similar nature (adding new field with transformer/provider update):
1612065 to
4fd7a7d
Compare
dav-pascual
reviewed
Mar 24, 2026
Member
dav-pascual
left a comment
There was a problem hiding this comment.
A couple of minor final comments
b89a2a0 to
d84e754
Compare
Allow passing per-OS user_data from provisioning config to ec2.create_instances().
This enables boot-time instance configuration (e.g. enabling OpenSSH on Windows)
without requiring custom AMIs.
in provisioning-config.yaml, user have to define user_data var and provide the set
of commands it needs to execute on aws provisioned host like:
```
aws:
images:
win-2025: <image-id>
win-2022: <image-id>
flavors:
default: t3.medium
...
user_data:
win-2025: |
<powershell>
# Set Administrator password (matches ad_admin_password in mhcfg)
net user Administrator Secret123
Restart-Service sshd
</powershell>
win-2022: |
<powershell>
# some commands
</powershell>
users:
win-2025: Administrator
win-2022: Administrator
```
Signed-off-by: Rizwan Shaikh <myusuf@redhat.com>
d84e754 to
f829ade
Compare
dav-pascual
approved these changes
Mar 25, 2026
f829ade to
da6a5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing per-OS user_data from provisioning config to ec2.create_instances(). This enables boot-time instance configuration (e.g. enabling OpenSSH on Windows) without requiring custom AMIs.
in provisioning-config.yaml, user have to define user_data var and provide the set of commands it needs to execute on aws provisioned host like: