Fix OpenAILLM and http_client type #404
Open
+599
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except ImportError: | ||
| raise ImportError( | ||
| """Could not import httpx. | ||
| Please install it with `pip install httpx.""" |
There was a problem hiding this comment.
typo: there is a missing backtick at the end of the pip command.
| if isinstance(http_client, self.httpx.Client) | ||
| else (None, http_client) | ||
| ) | ||
| sync_client, async_client = clients |
There was a problem hiding this comment.
The logic for extracting and applying http_client is repeated in both OpenAI and AzureOpenAI constructors. this can be part of a utility function that can be called in both places.
| @@ -35,6 +36,24 @@ def test_openai_llm_missing_dependency(mock_import: Mock) -> None: | |||
| OpenAILLM(model_name="gpt-4o") | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
shall we add more tests for cases like missing http clients, wrong types...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #401
Type of Change
Complexity
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):