Pipeline state dump and load #352
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellasia
reviewed
Jun 9, 2025
| .. code:: python | ||
|
|
||
| # Run pipeline until a specific component | ||
| state = await pipeline.run_until(data, stop_after="component_name", state_file="state.json") |
There was a problem hiding this comment.
If we are returning the state, I think it would be cleaner let to the user save it to file or not, I'm not sure adding the state_file option is helpful.
| result = await pipeline.resume_from(state, data, start_from="component_name") | ||
|
|
||
| # Alternatively, load state from file | ||
| result = await pipeline.resume_from(None, data, start_from="component_name", state_file="state.json") |
There was a problem hiding this comment.
Also because of that, None as first argument is not super nice IMHO :)
stellasia
reviewed
Jun 11, 2025
stellasia
reviewed
Jun 11, 2025
| keys_to_remove = [ | ||
| key for key in self._data.keys() if key.startswith(run_id_prefix) | ||
| ] | ||
| for key in keys_to_remove: |
There was a problem hiding this comment.
So here we are removing all results from a previous run with this run_id, right?
stellasia
reviewed
Jun 11, 2025
| @@ -140,6 +140,7 @@ def __init__( | |||
| } | |||
| """ | |||
| self.missing_inputs: dict[str, list[str]] = defaultdict() | |||
| self._current_run_id: Optional[str] = None | |||
There was a problem hiding this comment.
This can not be saved in the Pipeline instance, since concurrent runs will override it.
stellasia
reviewed
Jun 11, 2025
| @@ -600,20 +650,23 @@ async def run( | |||
| result=await self.get_final_results(orchestrator.run_id), | |||
| ) | |||
|
|
|||
| def dump_state(self, run_id: str) -> Dict[str, Any]: | |||
| def dump_state(self) -> Dict[str, Any]: | |||
There was a problem hiding this comment.
I guess we will need the run_id as parameter here as a consequence of my first comment
stellasia
reviewed
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces state management capabilities to the
Pipelineclass, enabling:run_untilresume_fromThe state includes pipeline configuration, execution results, and final results from previous runs. This feature is particularly useful for:
Type of Change
Complexity
Complexity: low
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):