-
Notifications
You must be signed in to change notification settings - Fork 79
Add tabbed examples for multiple node IDs #2512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
@@ -1464,39 +1464,64 @@ Now use the previously defined ID spaces when connecting the actors to movies. | |||
== Using multiple node IDs | |||
|
|||
A node header can contain multiple `ID` columns. | |||
The relationship data must then use a matching number of `START_ID` / `END_ID` columns as references to the composite value of those ID columns. | |||
|
|||
Starting from 2025.07, the relationship data must then use a matching number of `START_ID` / `END_ID` columns as references to the composite value of those ID columns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? If I read the comments for the https://github.com/neo-technology/neo4j/pull/31617 correctly, it is still allowed to use a single :START_ID/:END_ID to refer to a composite ID.
But it is not allowed to mix how to refer to composite IDs. Either all references must use a single :START_ID/:END_ID columns, or a matching amount.
I think this should be reflected on this page too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're right that it is still allowed to use a single :START_ID/:END_ID to refer to a composite ID, we don't want to document that behavior necessarily. It was never really meant to work that way and it is only still possible to not break potential usages of this behavior.
We want to encourage using a matching number of START_ID
/ END_ID
columns and the other possibility was not meant to exist and should therefor IMO not be documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I understand your intention, but the trick here is that the Operations manual covers also earlier versions of Neo4j (2025.01-2025.06), in which you cannot use matching number of START_ID
/ END_ID
columns. If a user is on 2025.02 and tries to follow the current example, he will get an error. Am I right?
Therefore we have to say that this functionality is available starting from 2025.07 and provide tabbed examples for earlier versions and for 2025.07.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I guess that makes sense.
[role=include-with-multiple-ID-columns label--new-2025.07] | ||
====== | ||
|
||
Starting from 2025.07, you have to use a matching number of `START_ID` / `END_ID` columns when defining the relationship: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting from 2025.07, you have to use a matching number of `START_ID` / `END_ID` columns when defining the relationship: | |
Starting from 2025.07, you can use a matching number of `START_ID` / `END_ID` columns when defining the relationship. | |
However, do not mix how to refer to composite IDs. | |
Either all references must use a single `START_ID` / `END_ID` column or a matching number of them. |
ebbc576
to
0519f55
Compare
This PR includes documentation updates Updated pages: |
The Operations manual covers all releases of 2025.xx series. That's why we cannot simply replace examples with new ones, as new functionality has been added. We also need to retain examples for earlier versions of Neo4j.