Skip to content

graph references in Cypher 25 #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2025
Merged

Conversation

nadja-muller
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's very USE centric, might be nice to have some mention of the admin commands as well and where they fall on the scales? 🤔

@nadja-muller nadja-muller requested a review from Hunterness June 5, 2025 08:37
@Hunterness Hunterness self-assigned this Jun 5, 2025
Copy link
Collaborator

@Hunterness Hunterness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some new comments 🎁

Comment on lines 182 to 184
In Cypher 5, there was some special logic for composite databases or constituents with dots,
which required quotes around those name parts in order to find the name. This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`]. In Cypher 25 the graph references can be passed in without quoting
as in the name column from `SHOW ALIASES FOR DATABASE`.Note that escaping graph names within the graph functions string argument is not supported in Cypher 5.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In Cypher 5, there was some special logic for composite databases or constituents with dots,
which required quotes around those name parts in order to find the name. This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`]. In Cypher 25 the graph references can be passed in without quoting
as in the name column from `SHOW ALIASES FOR DATABASE`.Note that escaping graph names within the graph functions string argument is not supported in Cypher 5.
In Cypher 5, there was some special logic for composite databases or constituents with dots, which required quotes around those name parts in order to find the name.
This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`].
In Cypher 25 the graph references can be passed in without quoting as in the name column from `SHOW ALIASES FOR DATABASE`.
Note that escaping graph names within the graph functions string argument is not supported in Cypher 5.

Usually we split the lines between sentences and not in the middle of sentences

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah...I guess there are no deprecations in cypher 25 yet. So this is about what we newly support. I'll try to reformulate this a little.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we would want to also add something for the removal of the old deprecation and introduction of the new + the breaking change, might be easier to just have that in this PR as well to not need 2 graph ref related cypher manual docs PRs 🤔

Copy link
Contributor Author

@nadja-muller nadja-muller Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woudn't it be better to port Louise's changes to this branch instead of doing them twice?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that we can take over the deprecations from neo4j/docs-status-codes#340 after that one is merged. This can also be in a follow up PR.

@JPryce-Aklundh JPryce-Aklundh self-assigned this Jun 10, 2025
@nadja-muller nadja-muller force-pushed the document-graph-references branch from 3726e9a to efdc42d Compare June 10, 2025 15:05
nadja-muller and others added 2 commits June 16, 2025 12:08
Co-authored-by: Jens Pryce-Åklundh <[email protected]>
Co-authored-by: Jens Pryce-Åklundh <[email protected]>
@neo4j-docops-agent
Copy link
Collaborator

neo4j-docops-agent commented Jun 16, 2025

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@JPryce-Aklundh JPryce-Aklundh merged commit 7e0c94f into cypher-25 Jun 16, 2025
4 checks passed
@JPryce-Aklundh JPryce-Aklundh deleted the document-graph-references branch June 16, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants