Skip to content

Polish the bottom panel UI #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

Polish the bottom panel UI #526

merged 3 commits into from
Jun 16, 2025

Conversation

nnecla
Copy link
Contributor

@nnecla nnecla commented Jun 13, 2025

This pr is to make some small polishes in the query results bottom panel. with these changes:

  • The icon button is removed from the collapsible component, as well as making the collapsible item accessible via keyboard.
  • Solving a small render issue, in which queryVisualization view was not rendered before posting a message from queryDetails part.(to reproduce the bug, collapse the queryVisualization view, restart the vscode, and run a query while queryVisualization is still collapsed.)
  • Polishing the table view to make it as similar as possible to the query experience with little effort 🙈
  • Making sure that the focus is kept in the editor if query results is already rendered
  • Making sure that theme changes are reflected from the bottom panel without requiring a restart.
Screenshot 2025-06-13 at 18 26 45

Copy link

changeset-bot bot commented Jun 13, 2025

⚠️ No Changeset found

Latest commit: 1bd17e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nnecla nnecla merged commit b9410f1 into main Jun 16, 2025
7 checks passed
@nnecla nnecla deleted the bottom-panel-ui-polish branch June 16, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants