fix: accept status='completed' in ToolCallStatus (#128) - #149
Open
1HazyOne707 wants to merge 2 commits into
Open
fix: accept status='completed' in ToolCallStatus (#128)#1491HazyOne707 wants to merge 2 commits into
1HazyOne707 wants to merge 2 commits into
Conversation
The hosted NAMS service returns status='completed' on successful tool calls, but ToolCallStatus only had PENDING/SUCCESS/FAILURE/ERROR/ TIMEOUT/CANCELLED, so record_tool_call() and get_session_traces() crashed with a ValidationError on any successful real-world call. Adds COMPLETED = "completed" to the enum (additive, non-breaking). Server-side this is being tracked separately at neo4j-labs/project-nams#74; this unblocks the SDK regardless. Closes neo4j-labs#128
|
@1HazyOne707 is attempting to deploy a commit to the lyonwj's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #128 — the hosted NAMS service returns
status='completed'on successful tool calls, butToolCallStatusonly definedPENDING/SUCCESS/FAILURE/ERROR/TIMEOUT/CANCELLED, sorecord_tool_call()andget_session_traces()crash with aValidationErroron any real successful tool call.Changes
COMPLETED = "completed"toToolCallStatus— additive and non-breaking, unblocks the SDK regardless of whether the server side is also addressed (tracked separately at neo4j-labs/project-nams#74)test_tool_call_accepts_completed_statustotests/unit/test_models.pyCloses #128