Add description line glue property (#481) #483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philipp91
reviewed
Jul 3, 2025
| /** | ||
| * @return $this | ||
| */ | ||
| public function setTransactionDescriptionLineGlue($transactionDescriptionLineGlue) |
There was a problem hiding this comment.
Add type for the argument?
| @@ -20,6 +20,14 @@ class SEPAAccount | |||
| /** @var string|null */ | |||
| protected $blz; | |||
|
|
|||
| /** | |||
| * Determines how single lines in transaction descriptions are joined, see #481. | |||
There was a problem hiding this comment.
This should somehow refer to MT940 / the fact that this is about transaction statements for this account.
| @@ -20,6 +20,14 @@ class SEPAAccount | |||
| /** @var string|null */ | |||
| protected $blz; | |||
|
|
|||
| /** | |||
| * Determines how single lines in transaction descriptions are joined, see #481. | |||
| * Defaults to an empty string for maximum compatibility but some banks implicitly assume line breaks for this. | |||
There was a problem hiding this comment.
I'd say "backwards compatibility" (with previous versions of this library) rather than "maximum compatibility" (with the largest number of banks).
| * @return $this | ||
| */ | ||
| public function setTransactionDescriptionLineGlue($transactionDescriptionLineGlue) | ||
| { |
There was a problem hiding this comment.
I left it out to match the other getters in this file.
|
Please merge it and change it yourself. This is so much faster than back and forth here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #481 by adding the optional property
transactionDescriptionLineGlueto SEPAAccount.